Skip to content

Fix examples page on mobile#1509

Merged
demiankatz merged 19 commits intoUniversalViewer:devfrom
Saira-A:examplespage
Jul 23, 2025
Merged

Fix examples page on mobile#1509
demiankatz merged 19 commits intoUniversalViewer:devfrom
Saira-A:examplespage

Conversation

@Saira-A
Copy link
Copy Markdown
Contributor

@Saira-A Saira-A commented Jul 22, 2025

Hides the IIIF/YouTube tabs at the top from view on mobile, therefore making mobileFooterPanel visible again and fixing #1501.

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 10:05am

Copy link
Copy Markdown
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Saira-A.

In an ideal world, maybe it would be better to figure out why the viewer is overflowing the page in mobile view when the tabs are visible, rather than just hiding the tabs. However, this solution is clear and simple and is functionally equivalent to what we had before we moved the tabs to the top, so I'm perfectly happy to approve it. It's still possible to test the YouTube mode in a mobile-sized window on a computer by switching tabs before changing window size -- and that was the only way to do it before as well.

If we really want full testing/debugging tools on true mobile, we probably need to figure out a way to navigate to the controls on a smaller screen. That's a big project that I don't think we need to prioritize right now.

Copy link
Copy Markdown
Collaborator

@LanieOkorodudu LanieOkorodudu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Saira-A for jumping in and handling this! Functionality-wise, this brings things back to how they were before, and it works as expected.

@demiankatz, I totally agree with you, having full access to all the controls on real mobile devices would be really nice. But yeah, that would likely require a bigger redesign. Definitely feels like something worth bringing up with the team and maybe adding to the roadmap when the timing makes sense. Right now, the mobile experience is just at the bare minimum for navigation, so this would definitely be a meaningful upgrade for mobile users.

In the meantime, this fix seems like a good step forward, so I’d say let’s go ahead and merge it. Thanks again, Saira!

@demiankatz demiankatz merged commit c3d43f2 into UniversalViewer:dev Jul 23, 2025
4 checks passed
@demiankatz
Copy link
Copy Markdown
Contributor

Thanks, @LanieOkorodudu and @Saira-A -- I have merged this now.

@demiankatz demiankatz mentioned this pull request Jul 23, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants