Fix examples page on mobile#1509
Conversation
Add collapsible headings and reset rotation button
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Thanks, @Saira-A.
In an ideal world, maybe it would be better to figure out why the viewer is overflowing the page in mobile view when the tabs are visible, rather than just hiding the tabs. However, this solution is clear and simple and is functionally equivalent to what we had before we moved the tabs to the top, so I'm perfectly happy to approve it. It's still possible to test the YouTube mode in a mobile-sized window on a computer by switching tabs before changing window size -- and that was the only way to do it before as well.
If we really want full testing/debugging tools on true mobile, we probably need to figure out a way to navigate to the controls on a smaller screen. That's a big project that I don't think we need to prioritize right now.
LanieOkorodudu
left a comment
There was a problem hiding this comment.
Thanks @Saira-A for jumping in and handling this! Functionality-wise, this brings things back to how they were before, and it works as expected.
@demiankatz, I totally agree with you, having full access to all the controls on real mobile devices would be really nice. But yeah, that would likely require a bigger redesign. Definitely feels like something worth bringing up with the team and maybe adding to the roadmap when the timing makes sense. Right now, the mobile experience is just at the bare minimum for navigation, so this would definitely be a meaningful upgrade for mobile users.
In the meantime, this fix seems like a good step forward, so I’d say let’s go ahead and merge it. Thanks again, Saira!
|
Thanks, @LanieOkorodudu and @Saira-A -- I have merged this now. |
Hides the IIIF/YouTube tabs at the top from view on mobile, therefore making mobileFooterPanel visible again and fixing #1501.