Avoid disabling all downloads on high res disable#1525
Merged
demiankatz merged 3 commits intoUniversalViewer:devfrom Aug 16, 2025
Merged
Avoid disabling all downloads on high res disable#1525demiankatz merged 3 commits intoUniversalViewer:devfrom
demiankatz merged 3 commits intoUniversalViewer:devfrom
Conversation
When disabling high res downloads in openseadragon, *all* downloads get disabled due to how these cases are grouped - instead, move the high res check up and allow fallthrough if it is enabled.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
demiankatz
previously approved these changes
Aug 16, 2025
Contributor
|
Prior to merging, I ran |
demiankatz
approved these changes
Aug 16, 2025
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1526
Description of what you did:
When disabling high res downloads in openseadragon, all downloads get disabled due to how these cases are grouped - instead, move the high res check up and allow fallthrough if it is enabled.
To test, I first repro'd the bug I'm seeing locally with the provided npm example. I used this manifest: https://qa-api-collections.nypl.org/manifests/510d47e3-2b96-a3d9-e040-e00a18064a99 (so that it would have canvas renderings for download). On the dev branch, if you set high res to true, but everything else as false, it works as expected:
However, if you flip high res to false, everything disappears:
After my change, setting high res to false still lets the manifest provided downloads show up:
