Release 4.3.0 rc4#1715
Conversation
|
@demiankatz is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I noticed something while using the keyboard(Tab navigation). Also, the Next and Previous buttons on the canvas show a highlight like in the screenshot. It feels a bit different compared to the previous version. |
|
Thanks for taking a look, @LanieOkorodudu! The focus on the canvas is intentional: when the canvas is focused, you can move the image with the arrow keys and zoom in and out with the -/+ keys. If you can't focus the canvas, this functionality is lost. It looks to me like the functionality already exists in 4.2.1, but the canvas doesn't show a focus outline, so it's less clear what is going on. That problem will be fixed in 4.3.0. I believe the change to the next/previous focus outline is related to the CSS changes that added the canvas outline. @jamesmisson and I also noticed that. I don't particularly like it, but I haven't had time to investigate how difficult it would be to fix. If anybody has time to correct it, I'd welcome the fix -- but if not, I don't think it's bad enough to delay the release. |
Yeah, I agree, I don't think this is a blocker. |
Fortunately, it was easy to fix in #1725! |
demiankatz
merged commit 784fb7a
into
UniversalViewer:release-4.3.0
3 participants
This is the fourth release candidate for 4.3.0, fixing more bugs discovered since RC3 (#1634) and updating further dependencies.
This RC also includes some further adjustments to the release workflow in an effort to get NPM publishing working again. Automatic publishing is still failing, however, so this release has been published manually.