Skip to content

Fix test suite by upgrading dependencies.#984

Merged
edsilv merged 12 commits intoUniversalViewer:devfrom
FalveyLibraryTechnology:puppeteer21
May 2, 2024
Merged

Fix test suite by upgrading dependencies.#984
edsilv merged 12 commits intoUniversalViewer:devfrom
FalveyLibraryTechnology:puppeteer21

Conversation

@demiankatz
Copy link
Copy Markdown
Contributor

@demiankatz demiankatz commented Apr 4, 2024

This pull request updates test-related dependencies in order to get the test suite running correctly.

TODO

  • Determine why some tests are getting skipped (answer: they were intentionally disabled in commit 9e5adf5).

@codesandbox
Copy link
Copy Markdown

codesandbox bot commented Apr 4, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 2:39pm

@demiankatz
Copy link
Copy Markdown
Contributor Author

I'm not sure why the codesandbox build is failing here. Any ideas?

@demiankatz
Copy link
Copy Markdown
Contributor Author

On the April 17, 2024 Steering Group call, I took some time to walk through the changes here with the British Library team. Our investigation revealed that the reason for skipped tests is that several tests were explicitly disabled with .skip in commit 9e5adf5 -- something that should be cleaned up at some point, but which does not raise any concerns about this upgrade changing behavior. It seems that everything is now working as expected from the Jest perspective.

We also took some time to restore a commented-out test back to a functional state, so we at least have a very simple test to confirm that the example page is properly loading a working manifest (though this test has the downside of being reliant on a third-party manifest, which makes it inherently brittle -- still, something is better than nothing).

There's just one remaining problem that I'm not sure how to solve: the CodeSandbox build is breaking here, and I have no idea why it passes in other branches and fails here when the only changes are test-related. The error seems to have something to do with LESS compilation, which is even more baffling. Is it possible that the changes to "transform" configuration required by the newer version of Jest are breaking LESS compilation? Seems like the likeliest possible theory, but I don't really understand why that would be the case. I also can't reproduce the error seen in the CodeSandbox output in my local environment. Puzzling all around! Any ideas, @edsilv?

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented May 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@demiankatz
Copy link
Copy Markdown
Contributor Author

I merged the latest dev branch, and now the codesandbox build is passing! Perhaps some of the other recent dependency updates resolved whatever issue was causing the failure.

@edsilv edsilv merged commit 5fdcb9b into UniversalViewer:dev May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

2 participants