Fix test suite by upgrading dependencies.#984
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I'm not sure why the codesandbox build is failing here. Any ideas? |
|
On the April 17, 2024 Steering Group call, I took some time to walk through the changes here with the British Library team. Our investigation revealed that the reason for skipped tests is that several tests were explicitly disabled with We also took some time to restore a commented-out test back to a functional state, so we at least have a very simple test to confirm that the example page is properly loading a working manifest (though this test has the downside of being reliant on a third-party manifest, which makes it inherently brittle -- still, something is better than nothing). There's just one remaining problem that I'm not sure how to solve: the CodeSandbox build is breaking here, and I have no idea why it passes in other branches and fails here when the only changes are test-related. The error seems to have something to do with LESS compilation, which is even more baffling. Is it possible that the changes to "transform" configuration required by the newer version of Jest are breaking LESS compilation? Seems like the likeliest possible theory, but I don't really understand why that would be the case. I also can't reproduce the error seen in the CodeSandbox output in my local environment. Puzzling all around! Any ideas, @edsilv? |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
I merged the latest dev branch, and now the codesandbox build is passing! Perhaps some of the other recent dependency updates resolved whatever issue was causing the failure. |
This pull request updates test-related dependencies in order to get the test suite running correctly.
TODO