Fix: remove duplicate IPC channel and extract error code sets#780
Merged
hazeone merged 1 commit intoValueCell-ai:mainfrom Apr 8, 2026
Merged
Conversation
- Remove duplicate 'channel:validate' entry in preload IPC whitelist - Extract inline error code arrays in Skills page to module-level Sets for O(1) lookup and better readability
Contributor
|
LGTM |
zjfjiayou
pushed a commit
to zjfjiayou/JitClaw
that referenced
this pull request
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small code quality improvements:
electron/preload/index.ts: Remove duplicate'channel:validate'entry in the IPC invoke whitelist (copy-paste oversight)src/pages/Skills/index.tsx: Extract inline error code arrays into module-levelSetconstants for O(1) lookup and better readabilityChanges
electron/preload/index.ts'channel:validate'entrysrc/pages/Skills/index.tsxINSTALL_ERROR_CODES,FETCH_ERROR_CODES,SEARCH_ERROR_CODESasSetTest plan
'channel:validate'(once, not twice)