Conversation
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
2 tasks
muukii
added a commit
that referenced
this pull request
Feb 3, 2026
## Summary - Create generic `ClosureBox<R>` in `withTracking.swift` to eliminate code duplication - Fix thunk stack growing for `didChange` closure in `withContinuousStateGraphTracking` by wrapping closures once at entry point and passing them directly in recursive calls - Remove duplicate private `ClosureBox` definitions from `withGraphTrackingGroup.swift` and `withGraphTrackingMap.swift` - Add `callAsFunction` support for cleaner invocation syntax ## Background PR #88 fixed thunk stack growing issue for handler closures by wrapping them in `ClosureBox`. However: 1. `ClosureBox` was duplicated in two files 2. `didChange` closure in `withContinuousStateGraphTracking` still had the same thunk stack growing issue due to recursive wrapping/unwrapping via `UnsafeSendable` ## Changes | File | Changes | |------|---------| | `withTracking.swift` | Add generic `ClosureBox<R>` with `callAsFunction`, add private `_withContinuousStateGraphTracking` | | `withGraphTrackingGroup.swift` | Remove private `ClosureBox`, use shared one | | `withGraphTrackingMap.swift` | Remove private `ClosureBox`, use shared one | ## Test plan - [x] `swift build` passes - [x] `swift test` passes (99 tests) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.