Skip to content

Add Target comparer and avoid string allocations. #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 1 commit into from
Apr 7, 2026
+12 −1
Merged

Add Target comparer and avoid string allocations. #1708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Verify/Verifier/VerifyEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ async Task Inner(FilePair file, Target target)
HandleCompareResult(result, file);
}

foreach (var group in targetList.GroupBy(_ => $"{_.Name}:{_.Extension}"))
foreach (var group in targetList.GroupBy(_ => _, TargetNameExtensionComparer.Instance))
{
var targets = group.ToList();
if (targets.Count == 1)
Expand Down Expand Up @@ -290,4 +290,15 @@ static void AcceptChanges(in FilePair file)
File.Delete(file.VerifiedPath);
File.Move(file.ReceivedPath, file.VerifiedPath);
}

private sealed class TargetNameExtensionComparer : IEqualityComparer<Target>
{
public static readonly TargetNameExtensionComparer Instance = new();

public bool Equals(Target x, Target y) =>
(x.Name ?? "") == (y.Name ?? "") && x.Extension == y.Extension;

public int GetHashCode(Target obj) =>
(obj.Name ?? "", obj.Extension).GetHashCode();
}
}
Loading