Skip to content

fix: completion installation #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felangel merged 1 commit into from
Feb 10, 2023
Merged

fix: completion installation #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/installer/completion_installation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ class CompletionInstallation {
configFile.writeAsStringSync(
mode: FileMode.append,
'''
## [$scriptName]
\n## [$scriptName]
## $description
${configuration!.sourceLineTemplate(scriptPath)}
## [/$scriptName]
Expand Down
17 changes: 11 additions & 6 deletions test/src/installer/completion_installation_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,8 @@ void main() {
expect(configFile.existsSync(), true);

// ignore: leading_newlines_in_multiline_strings
expect(configFile.readAsStringSync(), '''## [very_good]
expect(configFile.readAsStringSync(), '''
\n## [very_good]
## Completion config for "very_good"
[[ -f ${configDir.path}/very_good.zsh ]] && . ${configDir.path}/very_good.zsh || true
## [/very_good]
Expand Down Expand Up @@ -265,7 +266,8 @@ void main() {
installation.writeToShellConfigFile('very_good');

// ignore: leading_newlines_in_multiline_strings
expect(rcFile.readAsStringSync(), '''## [Completion]
expect(rcFile.readAsStringSync(), '''
\n## [Completion]
## Completion scripts setup. Remove the following line to uninstall
[[ -f ${configDir.path}/zsh-config.zsh ]] && . ${configDir.path}/zsh-config.zsh || true
## [/Completion]
Expand Down Expand Up @@ -372,7 +374,8 @@ void main() {
// rc fle includes one reference to the global config

// ignore: leading_newlines_in_multiline_strings
expect(rcFile.readAsStringSync(), '''## [Completion]
expect(rcFile.readAsStringSync(), '''
\n## [Completion]
## Completion scripts setup. Remove the following line to uninstall
[[ -f ${configDir.path}/zsh-config.zsh ]] && . ${configDir.path}/zsh-config.zsh || true
## [/Completion]
Expand All @@ -385,12 +388,13 @@ void main() {
);

// ignore: leading_newlines_in_multiline_strings
expect(globalConfig.readAsStringSync(), '''## [very_good]
expect(globalConfig.readAsStringSync(), '''
\n## [very_good]
## Completion config for "very_good"
[[ -f ${configDir.path}/very_good.zsh ]] && . ${configDir.path}/very_good.zsh || true
## [/very_good]

## [not_good]
\n## [not_good]
## Completion config for "not_good"
[[ -f ${configDir.path}/not_good.zsh ]] && . ${configDir.path}/not_good.zsh || true
## [/not_good]
Expand Down Expand Up @@ -423,7 +427,8 @@ void main() {
..install('not_good');

// ignore: leading_newlines_in_multiline_strings
expect(bashProfile.readAsStringSync(), '''## [Completion]
expect(bashProfile.readAsStringSync(), '''
\n## [Completion]
## Completion scripts setup. Remove the following line to uninstall
[ -f ${configDir.path}/bash-config.bash ] && . ${configDir.path}/bash-config.bash || true
## [/Completion]
Expand Down