fix!: avoid false negatives when the current version is a pre-release and there is a prior stable release on pub#42
Merged
wolfenrain merged 7 commits intomainfrom Apr 11, 2023
Conversation
…d and there is a prior stable release
65923cf to
71449ef
Compare
felangel
reviewed
Mar 28, 2023
| .thenAnswer((_) => Future.value(FakeProcessResult())); | ||
| }); | ||
|
|
||
| test('returns false when currentVersion < latestVersion', () async { |
Contributor
There was a problem hiding this comment.
So just to clarify if the current version was 0.1.0-dev.48 and the latest version was 1.0.0, isUpToDate would return true?
Contributor
Author
There was a problem hiding this comment.
I would say, in short, I think we shouldn't track how "up to date" a pre-release is when compared to a stable release because it is a rabbit hole (#41 (comment))
alestiago
reviewed
Mar 28, 2023
alestiago
reviewed
Mar 28, 2023
Contributor
|
I also had the same doubt that @felangel had here. Can we add some documentation in the Maybe a FAQ similar to how mocktail or very_good_coverage have? |
ac1e683 to
99a27ea
Compare
wolfenrain
previously approved these changes
Mar 29, 2023
Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
wolfenrain
approved these changes
Apr 3, 2023
alestiago
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix!: avoid false negatives when the current version is a pre-release and there is a prior stable release on pub
This is a breaking change, in the following case, that returned
false, will returntrueafter this change.closes: #41
Type of Change