fix: org name with 2 parts in identifier Ex. com.example

[toufeeqahamedns]

Description
org-name is not accepted when given a single identifier

Steps To Reproduce
For creating app with org name com.example we use very_good create --org-name com.example example but this creates an app with applicationId com.example.example which actually should have been com.example

If very_good create --org-name com example is used, it is not accepted as the identifier required 2 parts between .

flutter create --org com example creates the valid required applicationId com.example

Expected Behavior
very_good create --org-name com example should create an app with applicationId com.example

[marcossevilla]

hi @toufeeqahamedns 👋 thanks for the heads up!

For now, our CLI requires an organization domain, which is formatted as <domain>.<organization>.<project_name>, I don't see a case where creating a project with a <domain>.<project_name> format is required.

Android, for example, uses the Java package naming conventions. So I don't know if there's an error when uploading to Play Store or App Store if the package name doesn't follow these conventions.

Maybe you can provide more context about these aspects?

[toufeeqahamedns]

Hey @marcossevilla, thanks for highlighting on Java Package naming conventions, the guidlines defined accept identifiers with 2 parts.

The <domain>.<project_name> would be very much helpful when you have the project say google.com and want to use com.google as the identifier

Also as the flutter create and both native android and ios project setup wizards allow to create the projects with <domain>.<project_name> it would be good if very_good create support it as well

[marcossevilla]

I think if you have google.com as org_name it would miss the project_name, like com.google.gmail for example.

What we try to achieve with very_good_cli it's to have the standardized formatting of <domain>.<organization>.<project_name>.

Tagging @felangel and @jorgecoca to have some second thoughts on supporting this alternative.

[jolexxa]

I think rather than passing an organization name in, you should just be able to pass whatever bundle id you want in. I've been so confused when generating new projects and the cli tool appends the project name to the organization name I passed in. I'd much rather just pass in the bundle id instead of VG CLI trying to be smart enough to compose it from the organization name and project name (because sometimes the project folder name is different from the name i'd use in the bundle id).

[toufeeqahamedns]

I think if you have google.com as org_name it would miss the project_name, like com.google.gmail for example.

What if the org_name is your project name, as in google.com being the project and also the org name itself.

I'd much rather just pass in the bundle id instead of VG CLI trying to be smart enough to compose it from the organization name and project name

This would be a much better option

[marcossevilla]

I agree with @definitelyokay, using the bundle ID would be better than having the org_name and project_name composing it. I'm just doubting about the usage of org_name, if it's used solely on another part and if this change would break that usage. Labeling as investigating as this may require to map where org_name is used. 👍