Skip to content

fix: --min-coverage does not work when running with --recursive #389

@wolfenrain

Description

@wolfenrain

Description

Currently if you run very_good test --min-coverage 100 --recursive it will go through each package it finds and run the tests. But if any of those packages don't have 100% test coverage there won't be an error displaying that.

Here I am running the command at the root of my project:
image

It finds three packages, which is correct, but all three of them don't have 100% test coverage:

  • umbra_flutter: image
  • umbra_core: image
  • umbra_cli: image

Steps To Reproduce

  1. Create a repo with two packages, and ensure they don't have full test coverage
  2. Run very_good test --min-coverage 100 --recursive at the root
  3. Tests will succeed but no coverage is reported.

Expected Behavior
I expected that I was able to combine these flags together to run all my tests at the highest level and confirm that they all have the coverage I expected.

Related: #383

Metadata

Metadata

Assignees

Labels

bugSomething isn't working as expectedgood first issueGood for newcomers

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions