Skip to content

fix: allow spaced golden file names#722

Merged
alestiago merged 12 commits intomainfrom
fix/allow-spaces-in-golden-files
May 2, 2023
Merged

fix: allow spaced golden file names#722
alestiago merged 12 commits intomainfrom
fix/allow-spaces-in-golden-files

Conversation

@alestiago
Copy link
Contributor

Description

Fixes #565. Related to #651 and #720.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago self-assigned this Apr 13, 2023
@alestiago alestiago mentioned this pull request Apr 13, 2023
7 tasks
@alestiago alestiago marked this pull request as ready for review April 13, 2023 16:49
@alestiago
Copy link
Contributor Author

alestiago commented Apr 13, 2023

I'm expecting #721 (if merged) to be merged before this.

renancaraujo
renancaraujo previously approved these changes Apr 18, 2023
Base automatically changed from refactor/move-e2e-to-own-package to main April 24, 2023 17:11
@alestiago alestiago merged commit 0e63104 into main May 2, 2023
@alestiago alestiago deleted the fix/allow-spaces-in-golden-files branch May 2, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: very_good test fails when some tests have a space in their golden name

2 participants