Skip to content

fix: spaced golden file names#720

Closed
alestiago wants to merge 5 commits intomainfrom
fix/spaced-golden-file-names
Closed

fix: spaced golden file names#720
alestiago wants to merge 5 commits intomainfrom
fix/spaced-golden-file-names

Conversation

@alestiago
Copy link
Contributor

Description

Fixes #565. Related to #651.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago
Copy link
Contributor Author

Drafting (and hopefully closing) in favour of #722 since expectBuildClean should not be considering e2e fixtures.

@alestiago alestiago marked this pull request as draft April 13, 2023 16:49
@alestiago
Copy link
Contributor Author

Closing in favour of #722

@alestiago alestiago closed this Apr 25, 2023
@alestiago alestiago deleted the fix/spaced-golden-file-names branch October 17, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: very_good test fails when some tests have a space in their golden name

1 participant