refactor: include visibleForTesting annotation on test parameters

[alestiago]

Description

Throughout the codebase there are many instances where a class has optional parameters to allow dependency injection during testing, these should be annotated with visibleForTesting.

For example:

// lib/src/commands/create/commands/create_subcommand.dart
  CreateSubCommand({
    required Analytics analytics,
    required this.logger,
    required MasonGeneratorFromBundle? generatorFromBundle,
    required MasonGeneratorFromBrick? generatorFromBrick,
  })

We should intentionally and explicitly denote these as visibleForTesting as:

// lib/src/commands/create/commands/create_subcommand.dart
  CreateSubCommand({
    required Analytics analytics,
    required this.logger,
    @visibleForTesting required MasonGeneratorFromBundle? generatorFromBundle,
    @visibleForTesting required MasonGeneratorFromBrick? generatorFromBrick,
  })

Expected Behavior

• To have all parameters that are used exclusively for testing purposes be annotated with visibleForTesting.

Additional Context

• visibleForTesting

[superiorsd10]

Hello @alestiago and @BeatriceMitchell,
I hope you're doing well. I'd like to contribute to the very_good_cli and noticed that there's this open issue. Would it be possible to assign this issue to me? I'd be happy to work on it.

Thank you,

[superiorsd10]

Hello @alestiago,
Actually after running the command dart test, some of the tests are failing. So can you please help me out in resolving it?

[alestiago]

HI @superiorsd10 , thanks for letting us now! I'm happy to help! Do you mind opening a new issue with the test failure you're getting and information about your system (for example, output of flutter doctor)? This is mainly to avoid polluting this issue and to allow us referencing it if the same problem occurs.

[superiorsd10]

Hello @alestiago,
I've opened an issue regarding this. Please look into it.

some tests are failing on running dart test

Thank you,