Skip to content

feat: bump template bundles#1094

Merged
alestiago merged 1 commit intomainfrom
feat/bump-template-bundles
Jul 30, 2024
Merged

feat: bump template bundles#1094
alestiago merged 1 commit intomainfrom
feat/bump-template-bundles

Conversation

@github-actions
Copy link
Contributor

Please squash and merge me!

@github-actions github-actions bot requested a review from a team as a code owner July 30, 2024 14:23
@github-actions github-actions bot added the bot label Jul 30, 2024
@alestiago alestiago marked this pull request as draft July 30, 2024 14:29
@alestiago alestiago closed this Jul 30, 2024
@alestiago alestiago reopened this Jul 30, 2024
@alestiago
Copy link
Contributor

alestiago commented Jul 30, 2024

Do not merge, flame template fails with:

Error: Because very_good_flame_game_hooks depends on very_good_core_hooks from path which doesn't exist (could not find package very_good_core_hooks at "../../very_good_core/hooks"), version solving failed.

We have to update to depend as a git dependency over path dependency and file an issue in Mason to fail publishing hooks with path dependencies since they don't seemed to get cloned.

@github-actions github-actions bot force-pushed the feat/bump-template-bundles branch from 877e194 to f7d142e Compare July 30, 2024 15:01
@alestiago alestiago closed this Jul 30, 2024
@alestiago alestiago reopened this Jul 30, 2024
@alestiago
Copy link
Contributor

The issue reported at #1094 (comment), has now been solved

@alestiago alestiago marked this pull request as ready for review July 30, 2024 15:35
@alestiago alestiago merged commit 9c9c9dc into main Jul 30, 2024
@alestiago alestiago deleted the feat/bump-template-bundles branch July 30, 2024 15:35
matiasleyba pushed a commit to a-wallen/very_good_cli that referenced this pull request Jul 17, 2025
Co-authored-by: VGV Bot <vgvbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

2 participants