fix: wrap tests in group to fix issue #320#321
Closed
Giuspepe wants to merge 2 commits intoVeryGoodOpenSource:mainfrom
Closed
fix: wrap tests in group to fix issue #320#321Giuspepe wants to merge 2 commits intoVeryGoodOpenSource:mainfrom
Giuspepe wants to merge 2 commits intoVeryGoodOpenSource:mainfrom
Conversation
Contributor
|
Hi @Giuspepe 👋 Are you able to provide a link to a minimal reproduction sample that illustrates the problem you were encountering prior to wrapping each test in a group? Thanks! 🙏 |
Contributor
Author
|
Hey @felangel, I uploaded a minimal reproduction sample here: https://github.com/Giuspepe/very_good_cli/tree/sample/wrap-tests-in-group/test Running the tests with Running the tests with |
Contributor
|
This has been addressed via #329 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following issue: #320 (comment)
.test_runner.dartin agroupsosetUp/tearDownbodies are only run for the test declaring the bodies instead of running allsetUp/tearDownbodies for all testsChanged brick
Type of Change