fix(test): exit (non-zero) on test failure

lib/src/cli/cli.dart

@@ -33,7 +33,7 @@ class _Cmd {
     return result;
   }
 
-  static Iterable<Future> runWhere<T>({
+  static Iterable<Future<T>> runWhere<T>({
     required Future<T> Function(FileSystemEntity) run,
     required bool Function(FileSystemEntity) where,
     String cwd = '.',

lib/src/cli/flutter_cli.dart

@@ -111,7 +111,8 @@ class Flutter {
   }
 
   /// Run tests (`flutter test`).
-  static Future<void> test({
+  /// Returns a list of exit codes for each test process.
+  static Future<List<int>> test({
     String cwd = '.',
     bool recursive = false,
     bool collectCoverage = false,
@@ -131,7 +132,7 @@ class Flutter {
       await lcovFile.delete();
     }
 
-    await _runCommand(
+    final results = await _runCommand<int>(
       cmd: (cwd) async {
         void noop(String? _) {}
         final target = DirectoryGeneratorTarget(Directory(p.normalize(cwd)));
@@ -199,11 +200,12 @@ class Flutter {
       final coverage = coverageMetrics.percentage;
       if (coverage < minCoverage) throw MinCoverageNotMet(coverage);
     }
+    return results;
   }
 }
 
 /// Run a command on directories with a `pubspec.yaml`.
-Future<void> _runCommand<T>({
+Future<List<T>> _runCommand<T>({
   required Future<T> Function(String cwd) cmd,
   required String cwd,
   required bool recursive,
@@ -212,24 +214,25 @@ Future<void> _runCommand<T>({
     final pubspec = File(p.join(cwd, 'pubspec.yaml'));
     if (!pubspec.existsSync()) throw PubspecNotFound();
 
-    await cmd(cwd);
-    return;
+    return [await cmd(cwd)];
   }
 
-  final processes = _Cmd.runWhere(
+  final processes = _Cmd.runWhere<T>(
     run: (entity) => cmd(entity.parent.path),
     where: _isPubspec,
     cwd: cwd,
   );
 
   if (processes.isEmpty) throw PubspecNotFound();
 
+  final results = <T>[];
   for (final process in processes) {
-    await process;
+    results.add(await process);
   }
+  return results;
 }
 
-Future<void> _flutterTest({
+Future<int> _flutterTest({
   String cwd = '.',
   bool collectCoverage = false,
   List<String>? arguments,
@@ -238,7 +241,7 @@ Future<void> _flutterTest({
 }) {
   const clearLine = '\u001B[2K\r';
 
-  final completer = Completer<void>();
+  final completer = Completer<int>();
   final suites = <int, TestSuite>{};
   final groups = <int, TestGroup>{};
   final tests = <int, Test>{};
@@ -330,7 +333,11 @@ Future<void> _flutterTest({
             : lightRed.wrap('Some tests failed.')!;
 
         stdout('$clearLine${darkGray.wrap(timeElapsed)} $stats: $summary\n');
-        completer.complete();
+        completer.complete(
+          event.success == true
+              ? ExitCode.success.code
+              : ExitCode.unavailable.code,
+        );
       }
     },
     onError: completer.completeError,

lib/src/commands/test/test.dart

@@ -12,7 +12,7 @@ import 'package:very_good_cli/src/cli/cli.dart';
 typedef FlutterInstalledCommand = Future<bool> Function();
 
 /// Signature for the [Flutter.test] method.
-typedef FlutterTestCommand = Future<void> Function({
+typedef FlutterTestCommand = Future<List<int>> Function({
   String cwd,
   bool recursive,
   bool collectCoverage,
@@ -130,7 +130,7 @@ This command should be run from the root of your Flutter project.''',
 
     if (isFlutterInstalled) {
       try {
-        await _flutterTest(
+        final results = await _flutterTest(
           optimizePerformance:
               optimizePerformance && _argResults.rest.isEmpty && !updateGoldens,
           recursive: recursive,
@@ -148,6 +148,9 @@ This command should be run from the root of your Flutter project.''',
             ..._argResults.rest,
           ],
         );
+        if (results.any((code) => code != ExitCode.success.code)) {
+          return ExitCode.unavailable.code;
+        }
       } on MinCoverageNotMet catch (e) {
         _logger.err(
           '''Expected coverage >= ${minCoverage!.toStringAsFixed(2)}% but actual is ${e.coverage.toStringAsFixed(2)}%.''',

test/src/cli/flutter_cli_test.dart

@@ -330,7 +330,7 @@ void main() {
             stdout: logger.write,
             stderr: logger.err,
           ),
-          completes,
+          completion(equals([ExitCode.unavailable.code])),
         );
         verify(
           () => logger.write(
@@ -366,7 +366,7 @@ void main() {
             stdout: logger.write,
             stderr: logger.err,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(
@@ -405,7 +405,7 @@ void main() {
             stdout: logger.write,
             stderr: logger.err,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(
@@ -446,7 +446,7 @@ void main() {
             stdout: logger.write,
             stderr: logger.err,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(
@@ -482,7 +482,7 @@ void main() {
             stdout: logger.write,
             stderr: logger.err,
           ),
-          completes,
+          completion(equals([ExitCode.unavailable.code])),
         );
         verify(
           () => logger.write(
@@ -519,7 +519,7 @@ void main() {
             stdout: logger.write,
             stderr: logger.err,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(
@@ -552,7 +552,7 @@ void main() {
             stdout: logger.write,
             stderr: logger.err,
           ),
-          completes,
+          completion(equals([ExitCode.unavailable.code])),
         );
         verify(
           () => logger.write(
@@ -581,7 +581,10 @@ void main() {
         File(
           p.join(testDirectory.path, 'example_test.dart'),
         ).writeAsStringSync(testContents);
-        expectLater(Flutter.test(cwd: directory.path), completes);
+        expectLater(
+          Flutter.test(cwd: directory.path),
+          completion(equals([ExitCode.success.code])),
+        );
       });
 
       test('completes when there is a test directory (passing)', () async {
@@ -598,7 +601,7 @@ void main() {
             stdout: logger.write,
             stderr: logger.err,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(
@@ -632,7 +635,7 @@ void main() {
             stderr: logger.err,
             progress: logger.progress,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(() => logger.progress('Optimizing tests')).called(1);
         verify(
@@ -669,7 +672,7 @@ void main() {
             stderr: logger.err,
             progress: logger.progress,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(() => logger.progress('Optimizing tests')).called(1);
         verify(
@@ -705,7 +708,7 @@ void main() {
             stdout: logger.write,
             stderr: logger.err,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(
@@ -744,7 +747,7 @@ void main() {
             stderr: logger.err,
             arguments: [otherTest.path],
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(
@@ -781,7 +784,7 @@ void main() {
             stderr: logger.err,
             randomSeed: randomSeed,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(
@@ -826,7 +829,7 @@ void main() {
             stderr: logger.err,
             collectCoverage: true,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(
@@ -870,7 +873,7 @@ void main() {
             stderr: logger.err,
             collectCoverage: true,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(
@@ -913,7 +916,7 @@ void main() {
             collectCoverage: true,
             minCoverage: 100,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(
@@ -1001,7 +1004,7 @@ void main() {
             collectCoverage: true,
             minCoverage: 100,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(
@@ -1042,7 +1045,7 @@ void main() {
             collectCoverage: true,
             minCoverage: 50,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(
@@ -1083,7 +1086,7 @@ void main() {
             collectCoverage: true,
             minCoverage: 49,
           ),
-          completes,
+          completion(equals([ExitCode.success.code])),
         );
         verify(
           () => logger.write(

test/src/commands/test/test_test.dart

@@ -30,7 +30,7 @@ const expectedTestUsage = [
 
 // ignore: one_member_abstracts
 abstract class FlutterTestCommand {
-  Future<void> call({
+  Future<List<int>> call({
     String cwd = '.',
     bool recursive = false,
     bool collectCoverage = false,
@@ -87,7 +87,7 @@ void main() {
           stdout: any(named: 'stdout'),
           stderr: any(named: 'stderr'),
         ),
-      ).thenAnswer((_) async {});
+      ).thenAnswer((_) async => [0]);
       when<dynamic>(() => argResults['recursive']).thenReturn(false);
       when<dynamic>(() => argResults['coverage']).thenReturn(false);
       when<dynamic>(() => argResults['update-goldens']).thenReturn(false);
@@ -152,6 +152,27 @@ void main() {
       ).called(1);
     });
 
+    test('exits with 70 when tests do not pass', () async {
+      when(
+        () => flutterTest(
+          cwd: any(named: 'cwd'),
+          recursive: any(named: 'recursive'),
+          collectCoverage: any(named: 'collectCoverage'),
+          optimizePerformance: any(named: 'optimizePerformance'),
+          minCoverage: any(named: 'minCoverage'),
+          excludeFromCoverage: any(named: 'excludeFromCoverage'),
+          arguments: any(named: 'arguments'),
+          progress: any(named: 'progress'),
+          stdout: any(named: 'stdout'),
+          stderr: any(named: 'stderr'),
+        ),
+      ).thenAnswer(
+        (_) async => [ExitCode.success.code, ExitCode.unavailable.code],
+      );
+      final result = await testCommand.run();
+      expect(result, equals(ExitCode.unavailable.code));
+    });
+
     test('completes normally --recursive', () async {
       when<dynamic>(() => argResults['recursive']).thenReturn(true);
       final result = await testCommand.run();