feat(test): add --dart-define#492
Merged
felangel merged 10 commits intoVeryGoodOpenSource:mainfrom Sep 14, 2022
Merged
Conversation
Contributor
Author
|
FYI: It seems that the CI test task is a bit flaky. I got the following error on my first CI run. When I reran the CI task with the same code, it succeeded without any errors. https://github.com/VeryGoodOpenSource/very_good_cli/runs/8308620438?check_suite_focus=true |
felangel
approved these changes
Sep 14, 2022
Contributor
felangel
left a comment
There was a problem hiding this comment.
LGTM thanks so much for the contribution!
ahsanf
pushed a commit
to Arkabyte-Teknologi/very_good_cli
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR adds the
--dart-defineparameter to the test command.--dart-defineis used to define compile-time constants which are then available through theString.fromEnvironment,bool.fromEnvironment,int.fromEnvironment, anddouble.fromEnvironmentconstructors.Tests relying on such compile-time constants can currently not be run with
very_good test, because the command doesn't yet accept the--dart-defineparameter.An example where one would use a
--dart-definecompile-time constant is to switch between different environments or flavors of an app. E.g.--dart-define=APP_ENVIRONMENT=dev.This is useful because code as the following is automatically deleted in an optimization step when building an app:
Type of Change