Skip to content

feat(core): support application_id argument #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felangel merged 7 commits into from
Nov 17, 2022
Merged

feat(core): support application_id argument #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
16ee035
feat: adding application id argument
erickzanardo Nov 7, 2022
3a84e53
Merge branch 'main' into feat/application_id
erickzanardo Nov 7, 2022
ee8d2df
lint
erickzanardo Nov 7, 2022
c15cc6b
Merge branch 'main' into feat/application_id
erickzanardo Nov 16, 2022
f3ba09e
feat: updating bundles
erickzanardo Nov 17, 2022
66a1d85
update bundle
felangel Nov 17, 2022
a59c88f
apply suggestions
felangel Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/src/commands/create/create.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,11 @@ class CreateCommand extends Command<int> {
'windows',
help: 'The plugin supports the Windows platform.',
defaultsTo: 'true',
)
..addOption(
'application-id',
help: 'The bundle identifier on iOS or application id on Android. '
'(defaults to <org-name>.<project-name>)',
);
}

Expand Down Expand Up @@ -160,11 +165,13 @@ class CreateCommand extends Command<int> {
final windows = _argResults['windows'] as String? ?? 'true';
final executableName =
_argResults['executable-name'] as String? ?? projectName;
final applicationId = _argResults['application-id'] as String?;
var vars = <String, dynamic>{
'project_name': projectName,
'description': description,
'executable_name': executableName,
'org_name': orgName,
if (applicationId != null) 'application_id': applicationId,
'platforms': <String>[
if (android.toBool()) 'android',
if (ios.toBool()) 'ios',
Expand Down
38 changes: 22 additions & 16 deletions lib/src/commands/create/templates/very_good_core/very_good_core_bundle.dart
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions lib/src/commands/create/templates/very_good_dart_cli/very_good_dart_cli_bundle.dart
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions lib/src/commands/create/templates/very_good_dart_package/very_good_dart_package_bundle.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions ...commands/create/templates/very_good_flutter_package/very_good_flutter_package_bundle.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading