Conversation
renancaraujo
commented
Jan 13, 2023
felangel
reviewed
Jan 13, 2023
felangel
reviewed
Jan 13, 2023
felangel
reviewed
Jan 13, 2023
felangel
reviewed
Jan 13, 2023
felangel
reviewed
Jan 13, 2023
felangel
reviewed
Jan 13, 2023
felangel
reviewed
Jan 13, 2023
felangel
suggested changes
Jan 13, 2023
Contributor
felangel
left a comment
felangel
left a comment
There was a problem hiding this comment.
Overall LGTM but left a few comments that I think we should address. Lmk what you think.
wolfenrain
reviewed
Jan 13, 2023
renancaraujo
force-pushed
the
feat/docs-create
branch
from
7acfaee to
db67ad4
Compare
Co-authored-by: Scarlett Eliza <scarletteliza@gmail.com>
Co-authored-by: Scarlett Eliza <scarletteliza@gmail.com>
Co-authored-by: Scarlett Eliza <scarletteliza@gmail.com>
Co-authored-by: Scarlett Eliza <scarletteliza@gmail.com>
Co-authored-by: Scarlett Eliza <scarletteliza@gmail.com>
| -h, --help Print this usage information. | ||
|
|
||
| Available subcommands: | ||
| dart_cli Creates a new very good Dart CLI in the specified directory. |
Member
There was a problem hiding this comment.
As much as I love saying "very good", I wonder if we should repeat it on every template, take becomes quite heavy to read.
I would say that the previous description for item template was pretty good already.
| -h, --help Print this usage information. | ||
|
|
||
| Available subcommands: | ||
| dart_cli Creates a new very good Dart CLI in the specified directory. |
felangel
reviewed
Jan 17, 2023
felangel
reviewed
Jan 17, 2023
felangel
reviewed
Jan 17, 2023
felangel
reviewed
Jan 17, 2023
felangel
reviewed
Jan 17, 2023
felangel
previously approved these changes
Jan 17, 2023
Contributor
felangel
left a comment
felangel
left a comment
There was a problem hiding this comment.
Overall looks great, just left a few minor comments.
felangel
reviewed
Jan 17, 2023
Co-authored-by: Felix Angelov <felangelov@gmail.com>
Co-authored-by: Felix Angelov <felangelov@gmail.com>
Co-authored-by: Felix Angelov <felangelov@gmail.com>
Co-authored-by: Felix Angelov <felangelov@gmail.com>
Co-authored-by: Felix Angelov <felangelov@gmail.com>
felangel
approved these changes
Jan 17, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update readme, doc and docs site with the new "create" usage and a migration guide.
Nails #581
Type of Change