Skip to content

fix(test_optimizer): mismatch of versions on hook #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renancaraujo merged 2 commits into from
Mar 2, 2023
Merged

fix(test_optimizer): mismatch of versions on hook #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6de9328
fix(test_optimizer): mismatch of versions on hook
renancaraujo Mar 1, 2023
4ad440b
comment
renancaraujo Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test_optimizer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
build_hooks:
uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/dart_package.yml@v1
with:
dart_sdk: 2.19.0
dart_sdk: 2.18.0
working_directory: bricks/test_optimizer/hooks

verify_bundle:
Expand Down
2 changes: 1 addition & 1 deletion bricks/test_optimizer/hooks/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include: package:very_good_analysis/analysis_options.4.0.0.yaml
include: package:very_good_analysis/analysis_options.3.1.0.yaml
linter:
rules:
public_member_api_docs: false
5 changes: 4 additions & 1 deletion bricks/test_optimizer/hooks/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ dependencies:
mason: ">=0.1.0-dev.41 <0.1.0"
path: ^1.8.1


# Beware: on hooks, even dev dependencies have to be compatible to all dart versions covered by
Copy link
Contributor

@alestiago alestiago Mar 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can automate checking this?

Copy link
Contributor

@wolfenrain wolfenrain Mar 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2e testing of the test command

Copy link
Contributor Author

@renancaraujo renancaraujo Mar 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added #676 for this

# the sdk constraints above
dev_dependencies:
mocktail: ^0.3.0
test: ^1.22.2
very_good_analysis: ^4.0.0
very_good_analysis: ^3.1.0
2 changes: 1 addition & 1 deletion lib/src/commands/test/templates/test_optimizer_bundle.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.