Skip to content

refactor: add visibleForTesting annotations to testing-related parameters #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renancaraujo merged 7 commits into from
Oct 2, 2023
Merged

refactor: add visibleForTesting annotations to testing-related parameters #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4cabbc2
adding visibleForTesting annotation parameters exclusive for testing …
superiorsd10 Sep 30, 2023
1b42377
removing the visible-for-testing annotation from logger and pubUpdater
superiorsd10 Oct 2, 2023
2200be0
formatted the packages.dart file
superiorsd10 Oct 2, 2023
9c07e75
removing the visible-for-testing annotation from logger and pubUpdate…
superiorsd10 Oct 2, 2023
930f3b3
removed the unused meta import from command_runner.dart file
superiorsd10 Oct 2, 2023
5cba1de
resolving the push conflict
superiorsd10 Oct 2, 2023
bf0e1b6
Merge branch 'main' into visible-for-testing-annotation
renancaraujo Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,4 +128,4 @@ dart fix --apply
[conventional_commits_link]: https://www.conventionalcommits.org/en/v1.0.0
[bug_report_link]: https://github.com/VeryGoodOpenSource/very_good_cli/issues/new?assignees=&labels=bug&template=bug_report.md&title=fix%3A+
[very_good_core_link]: doc/very_good_core.md
[very_good_ventures_link]: https://verygood.ventures/?utm_source=github&utm_medium=banner&utm_campaign=CLI
[very_good_ventures_link]: https://verygood.ventures/?utm_source=github&utm_medium=banner&utm_campaign=CLI
4 changes: 2 additions & 2 deletions lib/src/commands/create/commands/create_subcommand.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ abstract class CreateSubCommand extends Command<int> {
/// {@macro create_subcommand}
CreateSubCommand({
required this.logger,
required MasonGeneratorFromBundle? generatorFromBundle,
required MasonGeneratorFromBrick? generatorFromBrick,
@visibleForTesting required MasonGeneratorFromBundle? generatorFromBundle,
@visibleForTesting required MasonGeneratorFromBrick? generatorFromBrick,
}) : _generatorFromBundle = generatorFromBundle ?? MasonGenerator.fromBundle,
_generatorFromBrick = generatorFromBrick ?? MasonGenerator.fromBrick {
argParser
Expand Down
5 changes: 3 additions & 2 deletions lib/src/commands/create/create.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'package:args/command_runner.dart';
import 'package:mason/mason.dart';
import 'package:meta/meta.dart';
import 'package:very_good_cli/src/commands/create/commands/commands.dart';

/// {@template create_command}
Expand All @@ -12,8 +13,8 @@ class CreateCommand extends Command<int> {
/// {@macro create_command}
CreateCommand({
required Logger logger,
MasonGeneratorFromBundle? generatorFromBundle,
MasonGeneratorFromBrick? generatorFromBrick,
@visibleForTesting MasonGeneratorFromBundle? generatorFromBundle,
@visibleForTesting MasonGeneratorFromBrick? generatorFromBrick,
}) {
// very_good create flutter_app <args>
addSubcommand(
Expand Down
4 changes: 2 additions & 2 deletions lib/src/commands/test/test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ class TestCommand extends Command<int> {
/// {@macro test_command}
TestCommand({
required Logger logger,
FlutterInstalledCommand? flutterInstalled,
FlutterTestCommand? flutterTest,
@visibleForTesting FlutterInstalledCommand? flutterInstalled,
@visibleForTesting FlutterTestCommand? flutterTest,
}) : _logger = logger,
_flutterInstalled = flutterInstalled ?? Flutter.installed,
_flutterTest = flutterTest ?? Flutter.test {
Expand Down