Skip to content

fix: ignore empty allowed or forbidden#868

Merged
alestiago merged 2 commits intomainfrom
alestiago/exclude-empty-allowed-forbidden-licenses
Oct 26, 2023
Merged

fix: ignore empty allowed or forbidden#868
alestiago merged 2 commits intomainfrom
alestiago/exclude-empty-allowed-forbidden-licenses

Conversation

@alestiago
Copy link
Contributor

Description

Ignores empty allow or forbidden.

After

very_good packages check licenses --allowed="" --forbidden="" 
# Reports, equivalent to `very_good packages check licenses`

very_good packages check licenses --allowed="MIT" --forbidden="" 
# Reports with allowed, equivalent to `very_good packages check licenses --allowed="MIT"`

very_good packages check licenses --allowed="" --forbidden="MIT" 
# Reports with forbidden, equivalent to `very_good packages check licenses --forbidden="MIT"`

Before

very_good packages check licenses --allowed="" --forbidden="" 
# Throws usage exception, cannot specify both allowed and forbidden options.

very_good packages check licenses --allowed="MIT" --forbidden="" 
# Throws usage exception, cannot specify both allowed and forbidden options.

very_good packages check licenses --allowed="" --forbidden="MIT" 
# Throws usage exception, cannot specify both allowed and forbidden options.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two optional nits, but looks great!

@alestiago alestiago merged commit 34aed53 into main Oct 26, 2023
@alestiago alestiago deleted the alestiago/exclude-empty-allowed-forbidden-licenses branch October 26, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants