refactor: Use relative path instead of absolute when running packages get#919
Merged
alestiago merged 13 commits intoVeryGoodOpenSource:mainfrom Dec 18, 2023
mrgnhnt96:main
Merged
refactor: Use relative path instead of absolute when running packages get#919alestiago merged 13 commits intoVeryGoodOpenSource:mainfrom mrgnhnt96:main
packages get#919alestiago merged 13 commits intoVeryGoodOpenSource:mainfrom
mrgnhnt96:main
Conversation
mrgnhnt96
changed the title
packages getpackages get
alestiago
previously approved these changes
Dec 15, 2023
Contributor
alestiago
left a comment
alestiago
left a comment
There was a problem hiding this comment.
Thank you for your contribution! Left a minor comments, overall LGTM! 💙
alestiago
approved these changes
Dec 18, 2023
wolfenrain
approved these changes
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
The change introduced in this PR is to clean up the console when the cwd is printed to console. Specifically when running
very_good packages get.There are times when the full path of the cwd is too long causing the logger to behave unexpectedly.
A solution to the problem is to shorten the path printed to console. Instead of printing the absolute path, the relative path is used.
Type of Change