refactor: Use relative path instead of absolute when running test#920
Merged
alestiago merged 7 commits intoVeryGoodOpenSource:mainfrom Dec 15, 2023
mrgnhnt96:test-paths
Merged
refactor: Use relative path instead of absolute when running test#920alestiago merged 7 commits intoVeryGoodOpenSource:mainfrom mrgnhnt96:test-paths
test#920alestiago merged 7 commits intoVeryGoodOpenSource:mainfrom
mrgnhnt96:test-paths
Conversation
mrgnhnt96
changed the title
testtest
alestiago
reviewed
Dec 14, 2023
Contributor
Author
|
Thanks for your review! See the respective changes and lmk if you have any other suggestions! |
alestiago
previously approved these changes
Dec 14, 2023
alestiago
reviewed
Dec 14, 2023
wolfenrain
previously approved these changes
Dec 14, 2023
alestiago
approved these changes
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #754
Status
READY
Description
The change introduced in this PR is to clean up the console when the cwd is printed. Specifically when running
very_good test.Sometimes the full path of the cwd is too long and would be cut off. If running recursively, this can leave the developer confused as to which directory was tested.
A solution to the problem is to shorten the path printed to console. Instead of printing the absolute path, the relative path is used.
Type of Change