style: Adding extra space to the application opening tag#126
Merged
alestiago merged 1 commit intoVeryGoodOpenSource:mainfrom Jun 19, 2024
Merged
style: Adding extra space to the application opening tag#126alestiago merged 1 commit intoVeryGoodOpenSource:mainfrom
alestiago merged 1 commit intoVeryGoodOpenSource:mainfrom
Conversation
and wearable meta data in AndroidManifest.xml templates
wolfenrain
reviewed
Jun 18, 2024
Contributor
wolfenrain
left a comment
wolfenrain
left a comment
There was a problem hiding this comment.
A typical off by one mistake! LGTM
wolfenrain
approved these changes
Jun 18, 2024
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and wearable meta data in AndroidManifest.xml templates. Fixes #125
Description
Discovered a missing space ahead of the
<applicationin the AndroidManifest.xml. It affected creation of Flutter app (create flutter_app), and upon code inspection I also saw the same pattern in Flame Game and Flutter Plugin creation. Besides that towards the end of the Wear app creation manifest had missing single spaces for thecom.google.android.wearable.standalonemeta-datatag.Ref VeryGoodOpenSource/very_good_cli#1067 and VeryGoodOpenSource/very_good_cli#1066
Type of Change