Skip to content

feat: Add format_directories option#113

Merged
renancaraujo merged 4 commits intoVeryGoodOpenSource:mainfrom
pablojimpas:feat/format-directories
May 15, 2023
Merged

feat: Add format_directories option#113
renancaraujo merged 4 commits intoVeryGoodOpenSource:mainfrom
pablojimpas:feat/format-directories

Conversation

@pablojimpas
Copy link
Contributor

Description

Analogous to the analyze_directories option that already exists. Allows the user to configure for which directories wants to check formatting. Useful for excluding generated code, for example.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link
Contributor

@renancaraujo renancaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very good
Very good

@renancaraujo
Copy link
Contributor

renancaraujo commented May 11, 2023

Closing and reopening to kick dead actions

@pablojimpas
Copy link
Contributor Author

Is this ready to be merged? CI already passed @renancaraujo

@renancaraujo
Copy link
Contributor

I was waiting for the 1.13 release, merging now

@renancaraujo renancaraujo merged commit a6d1ada into VeryGoodOpenSource:main May 15, 2023
@pablojimpas pablojimpas deleted the feat/format-directories branch May 15, 2023 14:30
@renancaraujo renancaraujo mentioned this pull request Sep 18, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants