Skip to content

feat: add format_line_length input #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renancaraujo merged 1 commit into from
May 17, 2023
Merged

feat: add format_line_length input #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/dart_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ on:
required: false
type: string
default: "."
format_line_length:
required: false
type: string
default: "80"
min_coverage:
required: false
type: number
Expand Down Expand Up @@ -77,7 +81,7 @@ jobs:
run: ${{inputs.setup}}

- name: ✨ Check Formatting
run: dart format --set-exit-if-changed ${{inputs.format_directories}}
run: dart format --line-length ${{inputs.format_line_length}} --set-exit-if-changed ${{inputs.format_directories}}

- name: 🕵️ Analyze
run: dart analyze --fatal-infos --fatal-warnings ${{inputs.analyze_directories}}
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/flutter_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ on:
required: false
type: string
default: "lib test"
format_line_length:
required: false
type: string
default: "80"
min_coverage:
required: false
type: number
Expand Down Expand Up @@ -87,7 +91,7 @@ jobs:
run: ${{inputs.setup}}

- name: ✨ Check Formatting
run: dart format --set-exit-if-changed ${{inputs.format_directories}}
run: dart format --line-length ${{inputs.format_line_length}} --set-exit-if-changed ${{inputs.format_directories}}

- name: 🕵️ Analyze
run: flutter analyze ${{inputs.analyze_directories}}
Expand Down
12 changes: 12 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ The Dart package workflow consists of the following steps:

**Default** `"stable"`

#### `format_line_length`

**Optional** The line-length preferred to run the `dart format` command with. Be aware that this does not change the behavior of the analysis step and longer lines could still make the workflow fail if the rule `lines_longer_than_80_chars` is used.

**Default** `"80"`

#### `min_coverage`

**Optional** The minimum coverage percentage allowed.
Expand Down Expand Up @@ -195,6 +201,12 @@ The Flutter package workflow consists of the following steps:

**Default** `""`

#### `format_line_length`

**Optional** The line-length preferred to run the `dart format` command with. Be aware that this does not change the behavior of the analysis step and longer lines could still make the workflow fail if the rule `lines_longer_than_80_chars` is used.

**Default** `"80"`

#### `min_coverage`

**Optional** The minimum coverage percentage allowed.
Expand Down