Skip to content

feat: add "--no-example" flag in dart pub get#183

Merged
tomarra merged 5 commits intoVeryGoodOpenSource:mainfrom
eliasreis54:feat/dart-no-example
May 30, 2024
Merged

feat: add "--no-example" flag in dart pub get#183
tomarra merged 5 commits intoVeryGoodOpenSource:mainfrom
eliasreis54:feat/dart-no-example

Conversation

@eliasreis54
Copy link
Contributor

@eliasreis54 eliasreis54 commented May 20, 2024

Status

READY

Description

Adding the --no-example argument in dart pub get.

closes #151

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@eliasreis54 eliasreis54 requested a review from a team as a code owner May 20, 2024 16:45
@tomarra tomarra changed the title feat(dart-no-example): add "--no-example" flag in dart pub get feat: add "--no-example" flag in dart pub get May 22, 2024
@tomarra tomarra merged commit 32ee951 into VeryGoodOpenSource:main May 30, 2024
@tomarra tomarra mentioned this pull request May 30, 2024
2 tasks

- name: 📦 Install Dependencies
run: dart pub get
run: dart pub get ${{(inputs.skip_example && '--no-example') || ''}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomarra @alestiago @eliasreis54 ⚠️ Watch out since there's a bug merged with this PR. The argument was renamed to no_example, however here is still called inputs.skip_example!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! I think it should fix #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

feat(dart_package): allow --no-example on dart pub get

5 participants