Skip to content

refactor: remove coverage action in favor of CLI#425

Merged
marcossevilla merged 15 commits intomainfrom
refactor/remove-vgc
Mar 19, 2026
Merged

refactor: remove coverage action in favor of CLI#425
marcossevilla merged 15 commits intomainfrom
refactor/remove-vgc

Conversation

@marcossevilla
Copy link
Member

@marcossevilla marcossevilla commented Mar 5, 2026

Status

READY

Description

Replacing Very Good Coverage with Very Good CLI

This update removes the separate very_good_coverage GitHub Action and consolidates test execution + coverage enforcement into a single step powered by the Very Good CLI.

What changed

  • The "Run Tests" and "Check Code Coverage" steps are now a single step. The CLI handles testing, coverage collection, and coverage enforcement all at once.
  • The CLI is installed from Git during the testing phase (temporary — will switch to pub.dev once the required CLI version is published).

How to test

Point your workflow reference to this branch:

Before

uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/dart_package.yml@v1
uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/flutter_package.yml@v1

After (for testing)

uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/dart_package.yml@refactor/remove-vgc
uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/flutter_package.yml@refactor/remove-vgc

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

juan-vgv
juan-vgv previously approved these changes Mar 16, 2026
Copy link

@juan-vgv juan-vgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval after testing with 5 different repos.

Fingers crossed we can get at least a couple more. Other than that changes look good and backwards compatible.

@marcossevilla marcossevilla marked this pull request as ready for review March 16, 2026 11:30
@marcossevilla marcossevilla requested a review from a team as a code owner March 16, 2026 11:30
omartinma
omartinma previously approved these changes Mar 17, 2026
@marcossevilla marcossevilla dismissed stale reviews from omartinma and juan-vgv via 62549e9 March 18, 2026 10:43
omartinma
omartinma previously approved these changes Mar 18, 2026
Co-authored-by: Marcos Sevilla <31174242+marcossevilla@users.noreply.github.com>
@marcossevilla marcossevilla requested a review from juan-vgv March 18, 2026 15:38
juan-vgv
juan-vgv previously approved these changes Mar 18, 2026
@marcossevilla marcossevilla merged commit b001826 into main Mar 19, 2026
9 checks passed
@marcossevilla marcossevilla deleted the refactor/remove-vgc branch March 19, 2026 08:19
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in VGV Open Source 🦄 🧙🌟 Mar 19, 2026
@vgvbot vgvbot mentioned this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants