feature: support PVC for VMSelect in deployments

[vrutkovs]

Chart name and version, where you feel a lack of requested feature
chart: victoria-metrics-cluster

Describe the solution you'd like
Support PVCs for VMSelects in deployment mode.

I'm not entirely sure this is implementable, as deployments don't have volumeClaimTemplates, but we should look into alternatives, i.e. RWX storage shared between VMSelect replicas?

[ccaillet1974]

Think we have to switch to statefuset for vmselect, which is the case in the helm but actually statefulset mode is totally ignored on my helm. I could provide values file if needed.

Same problematic for vlseclect if we want cache embedded on vlselect for queries

Regards,

[AndrewChubatiuk]

Think we have to switch to statefuset for vmselect, which is the case in the helm but actually statefulset mode is totally ignored on my helm. I could provide values file if needed.

hey @ccaillet1974
can you confirm you're using .Values.vmselect.mode: statefulSet?

[ccaillet1974]

Hi Andrew,

Maybe it’s due to a change in Helm because I had the values like this :

.Values.vmselect.mode: deployment

.Values.vmselect.statefulSet.enabled: true

.Values.vmselect.persisentVolume.enabled: true

It’s seems that this configuration values has changed. I test this changes as soon as possible and get back here to share results.

I also see that in previous Helm version the comment for vmselect.mode indicates only deployment or daemonset as available values statefulSet is not displayed on default values file.

[AndrewChubatiuk]

indicates only deployment or daemonset as available values

sorry, this is typo, fixed it yesterday

[AndrewChubatiuk]

@vrutkovs

I'm not entirely sure this is implementable, as deployments don't have volumeClaimTemplates, but we should look into alternatives, i.e. RWX storage shared between VMSelect replicas?

solution for this issue can only be described in docs, as RWX storage is not available out of box in k8s and PVC per deployment replica can be done by using deployment with 1 replica for each vmselect replica. Additionally we could mention that vmselect cache can be mounted to host path

[ccaillet1974]

Andrew,

It's deployed as statefulSet with the correct syntax on values file. I have to adjust security for vmselect like this to avoid issue on permission with PVC. fsGroup is mandatory for that.

securityContext:
    enabled: true
    allowPrivilegeEscalation: false
    capabilities:
      drop: [ ALL ]
    seccompProfile:
      type: RuntimeDefault
podSecurityContext:
    enabled: true
    fsGroup: 1000
    runAsNonRoot: true
    runAsUser: 1000
    runAsGroup: 1000