fix(config-reloader): set default image to match the operator version#2562
Merged
AndrewChubatiuk merged 1 commit intoVictoriaMetrics:masterfrom Nov 12, 2025
Merged
Conversation
arteonprifti
requested review from
AndrewChubatiuk,
Haleygo,
f41gh7 and
zekker6
as code owners
Collaborator
|
LGTM, could you please also add a changelog entry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the reloader version is the one here: https://github.com/VictoriaMetrics/operator/blob/2ee997984d1b6d8ec7c3f07eceb2aea40fc993b1/internal/config/config.go#L115 and it doesn't match the operator version.
This is to set it to match the operator version.
By the way before v0.62.0 setting
was enough to get the same version for the reloader, but I didn't dig into that much. So maybe there is a better way, in the operator code.