feat: breaking change - update otel lib#357
Merged
OlivierAlbertini merged 1 commit intoVilledeMontreal:masterfrom Oct 27, 2025
Merged
feat: breaking change - update otel lib#357OlivierAlbertini merged 1 commit intoVilledeMontreal:masterfrom
OlivierAlbertini merged 1 commit intoVilledeMontreal:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates OpenTelemetry libraries from version 1.0.x to 1.9.0/2.2.0 and Axios from 1.6.2 to 1.13.0. The OpenTelemetry update introduces breaking changes requiring migration from direct NoopTracer instantiation to using the standard trace.getTracer() API.
Key Changes:
- Migration from
NoopTracerconstructor totrace.getTracer()API across test files and core configuration - Update of OpenTelemetry semantic conventions from
SemanticResourceAttributestoATTR_SERVICE_NAME - Refactoring of OpenTelemetry example to use newer API patterns with
resourceFromAttributesand updated span processor initialization - CircleCI configuration updates to test against Node 20 and current versions instead of Node 18
Reviewed Changes
Copilot reviewed 16 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/workit/tests/functionals/camunda.spec.ts | Temporary workaround using node_modules path for NoopTracer import |
| packages/workit/package.json | Updated OpenTelemetry dependencies to 1.9.0/2.2.0 and Axios to 1.13.0 |
| packages/workit-types/package.json | Updated OpenTelemetry API to 1.9.0 |
| packages/workit-stepfunction-client/package.json | Updated OpenTelemetry API to 1.9.0 |
| packages/workit-core/tests/units/worker.spec.ts | Migrated from NoopTracer constructor to trace.getTracer() |
| packages/workit-core/src/config/container.ts | Migrated from NoopTracer constructor to trace.getTracer() |
| packages/workit-core/package.json | Updated OpenTelemetry dependencies to 1.9.0/2.2.0 |
| packages/workit-bpm-client/tests/functionals/camunda.spec.ts | Migrated from NoopTracer constructor to trace.getTracer() |
| packages/workit-bpm-client/package.json | Updated OpenTelemetry API to 1.9.0 and Axios to 1.13.0 |
| examples/parallel/package.json | Updated Axios to 1.13.0 |
| examples/opentelemetry/src/worker.ts | Major refactoring to use updated OpenTelemetry APIs and patterns |
| examples/opentelemetry/package.json | Updated all OpenTelemetry dependencies and Axios |
| examples/failure-strategy/package.json | Updated Axios to 1.13.0 |
| examples/binding/package.json | Updated Axios to 1.13.0 |
| examples/basic/package.json | Updated Axios to 1.13.0 |
| .circleci/config.yml | Updated Node version testing matrix and CircleCI config version |
Files not reviewed (5)
- packages/workit-bpm-client/package-lock.json: Language not supported
- packages/workit-core/package-lock.json: Language not supported
- packages/workit-stepfunction-client/package-lock.json: Language not supported
- packages/workit-types/package-lock.json: Language not supported
- packages/workit/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9bb4058 to
9261dbc
Compare
update axios Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
9261dbc to
776d4e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates OpenTelemetry libraries from version 1.0.x to 1.9.0/2.2.0 and Axios from 1.6.2 to 1.13.0. The OpenTelemetry update introduces breaking changes requiring migration from direct NoopTracer instantiation to using the standard trace.getTracer() API.
Key Changes:
Migration from NoopTracer constructor to trace.getTracer() API across test files and core configuration
Update of OpenTelemetry semantic conventions from SemanticResourceAttributes to ATTR_SERVICE_NAME
Refactoring of OpenTelemetry example to use newer API patterns with resourceFromAttributes and updated span processor initialization
CircleCI configuration updates to test against Node 20 and current versions instead of Node 18
Update axios package