Skip to content

feat: breaking change - update otel lib#357

Merged
OlivierAlbertini merged 1 commit intoVilledeMontreal:masterfrom
OlivierAlbertini:feature/otel-update
Oct 27, 2025
Merged

feat: breaking change - update otel lib#357
OlivierAlbertini merged 1 commit intoVilledeMontreal:masterfrom
OlivierAlbertini:feature/otel-update

Conversation

@OlivierAlbertini
Copy link
Member

@OlivierAlbertini OlivierAlbertini commented Oct 27, 2025

This PR updates OpenTelemetry libraries from version 1.0.x to 1.9.0/2.2.0 and Axios from 1.6.2 to 1.13.0. The OpenTelemetry update introduces breaking changes requiring migration from direct NoopTracer instantiation to using the standard trace.getTracer() API.

Key Changes:

Migration from NoopTracer constructor to trace.getTracer() API across test files and core configuration
Update of OpenTelemetry semantic conventions from SemanticResourceAttributes to ATTR_SERVICE_NAME
Refactoring of OpenTelemetry example to use newer API patterns with resourceFromAttributes and updated span processor initialization
CircleCI configuration updates to test against Node 20 and current versions instead of Node 18
Update axios package

@OlivierAlbertini OlivierAlbertini added vulnerability Use only for issue not for PR dependencies Pull requests that update a dependency file breaking labels Oct 27, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates OpenTelemetry libraries from version 1.0.x to 1.9.0/2.2.0 and Axios from 1.6.2 to 1.13.0. The OpenTelemetry update introduces breaking changes requiring migration from direct NoopTracer instantiation to using the standard trace.getTracer() API.

Key Changes:

  • Migration from NoopTracer constructor to trace.getTracer() API across test files and core configuration
  • Update of OpenTelemetry semantic conventions from SemanticResourceAttributes to ATTR_SERVICE_NAME
  • Refactoring of OpenTelemetry example to use newer API patterns with resourceFromAttributes and updated span processor initialization
  • CircleCI configuration updates to test against Node 20 and current versions instead of Node 18

Reviewed Changes

Copilot reviewed 16 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/workit/tests/functionals/camunda.spec.ts Temporary workaround using node_modules path for NoopTracer import
packages/workit/package.json Updated OpenTelemetry dependencies to 1.9.0/2.2.0 and Axios to 1.13.0
packages/workit-types/package.json Updated OpenTelemetry API to 1.9.0
packages/workit-stepfunction-client/package.json Updated OpenTelemetry API to 1.9.0
packages/workit-core/tests/units/worker.spec.ts Migrated from NoopTracer constructor to trace.getTracer()
packages/workit-core/src/config/container.ts Migrated from NoopTracer constructor to trace.getTracer()
packages/workit-core/package.json Updated OpenTelemetry dependencies to 1.9.0/2.2.0
packages/workit-bpm-client/tests/functionals/camunda.spec.ts Migrated from NoopTracer constructor to trace.getTracer()
packages/workit-bpm-client/package.json Updated OpenTelemetry API to 1.9.0 and Axios to 1.13.0
examples/parallel/package.json Updated Axios to 1.13.0
examples/opentelemetry/src/worker.ts Major refactoring to use updated OpenTelemetry APIs and patterns
examples/opentelemetry/package.json Updated all OpenTelemetry dependencies and Axios
examples/failure-strategy/package.json Updated Axios to 1.13.0
examples/binding/package.json Updated Axios to 1.13.0
examples/basic/package.json Updated Axios to 1.13.0
.circleci/config.yml Updated Node version testing matrix and CircleCI config version
Files not reviewed (5)
  • packages/workit-bpm-client/package-lock.json: Language not supported
  • packages/workit-core/package-lock.json: Language not supported
  • packages/workit-stepfunction-client/package-lock.json: Language not supported
  • packages/workit-types/package-lock.json: Language not supported
  • packages/workit/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

update axios

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@OlivierAlbertini OlivierAlbertini self-assigned this Oct 27, 2025
@OlivierAlbertini OlivierAlbertini merged commit 3b2e755 into VilledeMontreal:master Oct 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking dependencies Pull requests that update a dependency file vulnerability Use only for issue not for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants