Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Comments

Warn on all parsing issues#151

Merged
domenic merged 8 commits intomasterfrom
more-warnings
Jul 12, 2019
Merged

Warn on all parsing issues#151
domenic merged 8 commits intomasterfrom
more-warnings

Conversation

@domenic
Copy link
Collaborator

@domenic domenic commented Jul 10, 2019

Closes #80.


Preview | Diff

domenic added 6 commits July 10, 2019 18:12
a7f9cdd fixed an issue in the spec where relative URL-like specifiers could cause URL parsing failures that were not handled. The reference implementation and tests were not updated at that time; this does so.
Part of #80. The included specifier key parsing test ensures that no warnings are given for specifier keys that can't be parsed as URLs; instead they are left alone.
@domenic domenic requested a review from guybedford July 10, 2019 22:14
domenic added 2 commits July 11, 2019 13:55
Always refer to "addresses", not "target addresses", and "specifier keys", not "specifiers".
@domenic domenic added this to the MVP milestone Jul 11, 2019
@domenic domenic merged commit 03aa2e0 into master Jul 12, 2019
@domenic domenic deleted the more-warnings branch July 12, 2019 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parsing: fail hard or fail soft?

1 participant