Tweaks and fixes to Memory64 proposal #1839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @rossberg for looking into this. I had been meaning to ask you to go through some of the interpreter changes (since some of them I make while resolving conflicts and I think where unreviewed), but you beat me to it. I do think for the sake of keeping the history of this proposal in one place it might me good to land these changes in the memory64 repo before merging. Is that what you mean by "Feel free to upstream back to the repo as you see fit"? I'm happy to do that. |
bvisness
approved these changes
Nov 6, 2024
document/core/exec/instructions.rst
Outdated
| 5. Let :math:`\X{mem}` be the :ref:`memory instance <syntax-meminst>` :math:`S.\SMEMS[a]`. | ||
|
|
||
| 6. Let :math:`\X{at}~\limits` be the :ref:`memory type <syntax-memtype>` :math:`\X{mem}.\MITYPE`. | ||
| 6. Assert: due to :ref:`validation <valid-load-extend>`, a value of :ref:`adress type <syntax-addrtype>` :math:`\X{at}` is on the top of the stack. |
Member
Author
Yes, sounds good! |
sbc100
added a commit
to WebAssembly/memory64
that referenced
this pull request
Nov 6, 2024
Split out from WebAssembly/spec#1839
sbc100
added a commit
to WebAssembly/memory64
that referenced
this pull request
Nov 6, 2024
Interpreter: - Fixed evaluation of v128 load/store instructions to work with i64 - Reworked bulk operation execution to still reduce to well-typed instructions for i32 - Added missing size check to table allocation - Various minor refactorings and clean-ups Tests: - Added tests for size check in i64 table and memory type limits Split out from WebAssembly/spec#1839
This was referenced Nov 6, 2024
sbc100
added a commit
to WebAssembly/memory64
that referenced
this pull request
Nov 6, 2024
Split out from WebAssembly/spec#1839
sbc100
added a commit
to WebAssembly/memory64
that referenced
this pull request
Nov 6, 2024
- Removed unnecessary/mismatching lookup of table/memory type in execution prose - Added missing result type lookup in formal rule for table.size and memory.size - Fixed computation of -1 result value for table.grow and table.size to work for i64 - Some fixes around specification of text format for inline elements/data shorthand - Fixed matching rules for tabletype/memtype to enforce same address type Split out from WebAssembly/spec#1839
sbc100
added a commit
to WebAssembly/memory64
that referenced
this pull request
Nov 6, 2024
Interpreter: - Fixed evaluation of v128 load/store instructions to work with i64 - Reworked bulk operation execution to still reduce to well-typed instructions for i32 - Added missing size check to table allocation - Various minor refactorings and clean-ups Tests: - Added tests for size check in i64 table and memory type limits Split out from WebAssembly/spec#1839
Member
|
I think all these changes have now landed downstream in the memory64 repo |
sbc100
added a commit
to WebAssembly/memory64
that referenced
this pull request
Nov 6, 2024
Interpreter: - Fixed evaluation of v128 load/store instructions to work with i64 - Reworked bulk operation execution to still reduce to well-typed instructions for i32 - Added missing size check to table allocation - Various minor refactorings and clean-ups Tests: - Added tests for size check in i64 table and memory type limits Split out from WebAssembly/spec#1839
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for merging the proposal to the wasm-3.0 branch, this PR fixes various smaller issues I discovered when going through the diffs for the merge.
Spec:
table.sizeandmemory.sizetable.growandtable.sizeto work for i64Interpreter:
Tests:
@sbc100, PTAL. Feel free to upstream back to the repo as you see fit.
Also, it would be good if you could add some tests for SIMD load/stores on i64 memories, since those were broken in the interpreter.