Add comment for ARM64 package installation to README.md#515
Merged
alexcrichton merged 2 commits intoWebAssembly:mainfrom Feb 17, 2025
Merged
Add comment for ARM64 package installation to README.md#515alexcrichton merged 2 commits intoWebAssembly:mainfrom
alexcrichton merged 2 commits intoWebAssembly:mainfrom
Conversation
yomaytk
changed the title
sbc100
reviewed
Feb 15, 2025
README.md
Outdated
| ```shell script | ||
| WASI_OS=linux | ||
| WASI_ARCH=x86_64 | ||
| WASI_ARCH=x86_64 // (`WASI_ARCH=arm64` for ARM64 package) |
Member
There was a problem hiding this comment.
How about # or 'arm64' if running on arm64 host
(# is the command char in the scripts)
Contributor
Author
There was a problem hiding this comment.
@sbc100
Thank you for the review. I fixed a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I added
WASI_ARCH=arm64command for the arm64 package version to the installation command’s comment. I thought this would make the command more clear.