Enable pthreads in libc++ for THREAD_MODEL=single#548
Merged
alexcrichton merged 1 commit intoWebAssembly:mainfrom Jul 27, 2025
Merged
Enable pthreads in libc++ for THREAD_MODEL=single#548alexcrichton merged 1 commit intoWebAssembly:mainfrom
THREAD_MODEL=single#548alexcrichton merged 1 commit intoWebAssembly:mainfrom
Conversation
4f0670b to
d25afce
Compare
alexcrichton
approved these changes
Jul 26, 2025
d25afce to
8b37dde
Compare
Contributor
Author
|
This PR of course shouldn't be merged as-is because the submodule shound point to the merge commit in wasi-libc. |
This commit enables thread support in libc++ for all thread models, enabling C++ applications that use threading APIs like `<atomic>` but do not spawn threads (e.g. Clang) to be built with minimal changes. Fixes WebAssembly#546.
8b37dde to
fb2ae11
Compare
Contributor
Author
|
Updated with proper |
Contributor
Author
|
@alexcrichton I have compiled Clang with the current HEAD and it builds and runs fine. |
kateinoigakukun
added a commit
to kateinoigakukun/icu
that referenced
this pull request
Jul 27, 2025
Thanks to recent wasi-libc changes, wasi-libc and libc++ in wasi-sdk now provides `std::atomic`, `std::mutex`, and other thread-related APIs even for wasm32-wasip1 target. * WebAssembly/wasi-libc#602 * WebAssembly/wasi-sdk#548
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enables thread support in libc++ for all thread models, enabling C++ applications that use threading APIs like
<atomic>but do not spawn threads (e.g. Clang) to be built with minimal changes.Fixes #546.
Depends on WebAssembly/wasi-libc#602.