Skip to content

Fix panic running with no args #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WillAbides merged 2 commits into from
Dec 22, 2023
Merged

Fix panic running with no args #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b446303
fix npe running with no args
WillAbides Dec 22, 2023
39defea
fix tests running on darwin/arm64
WillAbides Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/bindown/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ type rootCmd struct {
}

func (r *rootCmd) BeforeApply(k *kong.Context) error {
if k == nil || k.Selected() == nil {
return nil
}
// set dependency positional to optional for install, wrap, download and extract.
// We do this because we want to allow --all to be equivalent to specifying all
// dependencies but want the help output to indicate that a dependency is required.
Expand Down
2 changes: 2 additions & 0 deletions cmd/bindown/dependency_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,7 @@ dependencies:
runner := newCmdRunner(t)
srcFile := filepath.Join(runner.tmpDir, "template-source.yaml")
runner.writeConfigYaml(fmt.Sprintf(`
systems: ["linux/amd64", "darwin/amd64"]
url_checksums:
foo-linux-amd64-1.2.3: deadbeef
foo-darwin-amd64-1.2.3: deadbeef
Expand Down Expand Up @@ -436,6 +437,7 @@ dependencies:
runner := newCmdRunner(t)
srcFile := filepath.Join(runner.tmpDir, "template-source.yaml")
runner.writeConfigYaml(fmt.Sprintf(`
systems: ["linux/amd64", "darwin/amd64"]
url_checksums:
foo-linux-amd64-1.2.3: deadbeef
foo-darwin-amd64-1.2.3: deadbeef
Expand Down