Skip to content

Option to switch default tab label to New#117

Merged
WillyJL merged 6 commits intoWillyJL:mainfrom
r37r05p3C7:default-new
Jan 31, 2024
Merged

Option to switch default tab label to New#117
WillyJL merged 6 commits intoWillyJL:mainfrom
r37r05p3C7:default-new

Conversation

@r37r05p3C7
Copy link
Copy Markdown
Contributor

@r37r05p3C7 r37r05p3C7 commented Jan 30, 2024

Here is what i'm talking about.
Feel free to close it right away if you don't like it.
image
image

@WillyJL
Copy link
Copy Markdown
Owner

WillyJL commented Jan 30, 2024

I see what you mean. Yeah, that I can live with. Although maybe at this point could instead allow customizing the default tab? Could do like the settings do, and store an entry in the database by default with id -1, and check when deleting? Or id null? I'm not sure if AUTOINCREMENT allows that... I'll double check that and see what can be done about customizing the default tab. If nothing comes of it, I'll merge this.

Another thing though, we might benefit from having a settings section for tabs. Then the "filter in all tabs" can go there too... mind doing that real quick? Im busy with something else rn, but can do it later if you don't before me

@r37r05p3C7
Copy link
Copy Markdown
Contributor Author

r37r05p3C7 commented Jan 30, 2024

Although maybe at this point could instead allow customizing the default tab?

i was considering this option, but there is no use cases i could think of for default tab except being a tab for everything(if you are not using tabs at all) or being a staging area of sorts for new games, thus 2 hardcoded options.

@WillyJL WillyJL merged commit b0299f2 into WillyJL:main Jan 31, 2024
@r37r05p3C7 r37r05p3C7 deleted the default-new branch January 31, 2024 22:18
@r37r05p3C7
Copy link
Copy Markdown
Contributor Author

Tab.first_tab_label[0]
nice, sometimes i forget that python operates on unicode chars by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants