Skip to content

Option to enable independent sorting and column preferences for each tab#126

Merged
WillyJL merged 4 commits intoWillyJL:mainfrom
r37r05p3C7:independent-tab-views
Feb 7, 2024
Merged

Option to enable independent sorting and column preferences for each tab#126
WillyJL merged 4 commits intoWillyJL:mainfrom
r37r05p3C7:independent-tab-views

Conversation

@r37r05p3C7
Copy link
Copy Markdown
Contributor

Code is self-explanatory, imgui will store preferences for each tab separately based on tab id.

@r37r05p3C7
Copy link
Copy Markdown
Contributor Author

r37r05p3C7 commented Feb 6, 2024

encountered a weird bug, appears randomly. after enabling independent views, changing preferences on each tab, and then changing tabs a couple of times - sorting breaks. table header shows that sorting is applied, but rows are not sorted properly.

image

any idea why this is happening?

@r37r05p3C7
Copy link
Copy Markdown
Contributor Author

after reapplying sorting in one table, other tables return to normal as well. only a display issue? maybe something related to sort spec?

@r37r05p3C7
Copy link
Copy Markdown
Contributor Author

sorting also fixed after disabling independent views and enabling them again

@r37r05p3C7
Copy link
Copy Markdown
Contributor Author

imgui does not set table spec dirty flag sometimes when dealing with this configuration, i have no idea why. setting recalculate_ids fixes it because it is a part of the same or condition, i'm not sure if it's a good idea, but it works.

@WillyJL
Copy link
Copy Markdown
Owner

WillyJL commented Feb 6, 2024

Makes sense, to imgui its a different table. Showing a different table doesn't mean this table changed sorting mode. So yes, that is the correct way to force to to sort again

@WillyJL WillyJL merged commit aa0a640 into WillyJL:main Feb 7, 2024
@r37r05p3C7 r37r05p3C7 deleted the independent-tab-views branch February 8, 2024 07:55
@WillyJL WillyJL changed the title Option to enable independent sorting and filtering preferences for each tab Option to enable independent sorting and column preferences for each tab Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants