Fix windows registry key needed for startup#156
Merged
WillyJL merged 6 commits intoWillyJL:mainfrom Dec 13, 2024
Merged
Conversation
Owner
|
indeed, i can atleast confirm that it shows up and disappears from task manager's startup tab, which the current implementation does not. very weird, i couldve sworn it worked. ill check if it starts when i reboot. however those quotation marks concern me 🤔 start_cmd is quoted with shlex, to ensure proper parsing of following arguments. if indeed |
Contributor
Author
|
Haven't tested it as much, but I think it should also work without any quotes at all if that's preferable. |
WillyJL
approved these changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if it used to work as-is, or maybe still does for some, but at least for me (on version 10.0.22631 Build 22631) I needed to make 2 changes to get F95Checker to run on start up:
Either of these changes on their own didn't work for me.