Merged
Conversation
Closed
Contributor
Author
|
Checked HTTP and SOCKS5 proxy on windows build (btw, python 3.13 and current version of imgui - 2.0.0 - aren't compatible), both works just fine. |
Contributor
Author
|
Update: chromium doesn't support authentication for SOCKS5. So only HTTP proxy option is available for authentication dialog via Qt |
5f53353 to
62ca38e
Compare
Owner
|
ill have a look at this and fix merge conflicts soon, goes for other prs too |
62ca38e to
50de4c5
Compare
Contributor
Author
|
rebased on main and solved conflicts |
50de4c5 to
ed6f010
Compare
WillyJL
reviewed
Nov 19, 2024
Owner
WillyJL
left a comment
There was a problem hiding this comment.
mostly minor stylistic comments, ill get those fixed up myself :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added proxy support
Notes:
upd: I know there is an option to configure aiohttp in a way it'll pick proxy configuration from env, but I decided that straightforward configuration through application itself is better than that.