Skip to content

Support proxy for network calls#171

Merged
WillyJL merged 5 commits intoWillyJL:mainfrom
disaster2395:proxy-support
Nov 19, 2024
Merged

Support proxy for network calls#171
WillyJL merged 5 commits intoWillyJL:mainfrom
disaster2395:proxy-support

Conversation

@disaster2395
Copy link
Copy Markdown
Contributor

@disaster2395 disaster2395 commented Oct 26, 2024

Added proxy support

Notes:

  • Haven't checked if proxy really affect webview authentication process, but I hope it does
  • Tested proxy (HTTP ans SOCKS5) for aiohttp calls
  • SOCKS4 won't work in Qt (login dialog) because it's not supported
  • SOCKS5 with authorization won't work in Qt (login dialog) because of chromium limitations
  • HTTP(S) with authorization won't work in Qt (login dialog) because I haven't implemented it (there is different approach how to "set" proxy with/without credentials)
  • Changes in proxy configuration require app restart because I used "connector" approach for aiohttp instead of setting proxy for every request. Searching how to reconfigure session while it's being use through context manager was too much for me

upd: I know there is an option to configure aiohttp in a way it'll pick proxy configuration from env, but I decided that straightforward configuration through application itself is better than that.

@disaster2395 disaster2395 mentioned this pull request Oct 26, 2024
@disaster2395
Copy link
Copy Markdown
Contributor Author

disaster2395 commented Oct 26, 2024

Checked HTTP and SOCKS5 proxy on windows build (btw, python 3.13 and current version of imgui - 2.0.0 - aren't compatible), both works just fine.

@disaster2395
Copy link
Copy Markdown
Contributor Author

Update: chromium doesn't support authentication for SOCKS5. So only HTTP proxy option is available for authentication dialog via Qt

@WillyJL
Copy link
Copy Markdown
Owner

WillyJL commented Nov 18, 2024

ill have a look at this and fix merge conflicts soon, goes for other prs too

@disaster2395
Copy link
Copy Markdown
Contributor Author

rebased on main and solved conflicts

Copy link
Copy Markdown
Owner

@WillyJL WillyJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly minor stylistic comments, ill get those fixed up myself :D

Copy link
Copy Markdown
Owner

@WillyJL WillyJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@WillyJL WillyJL added the feature New feature or request label Nov 19, 2024
@WillyJL WillyJL merged commit b28bdb7 into WillyJL:main Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants