Open
Conversation
9365776 to
3ffa342
Compare
|
This is working. Tested on my fork. Also improves launch time significantly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257
I checked the compiled build for arm64, and it works correctly.
Here's how Claude Code explained why these changes will be enough:
Details
Dependency analysis and fixes
Dependencies without ARM64 wheels on macOS:
All other dependencies (
zstd,bencode2,pillow-avif-plugin,lxml,cx-Freeze, etc.) already have native ARM64 or universal2 wheels.Changes made to
.github/workflows/build.yml:macos-15(Apple Silicon / ARM64) to the build matrixartifactfield to each matrix entry for unique artifact names:Windows,Linux,macOS,macOS-ARM64— replacing the previousrunner.oswhich produced the same namemacOSfor both macOS buildsWhy this works:
On the ARM64 runner (
macos-15), pip won't find compatible wheels forimgui==2.0.0(x86_64 only) and will automatically fall back to building from sdist. The sdist already contains pre-generated C files, and Xcode Command Line Tools (pre-installed on GitHub runners) will compile them into a native ARM64 binary.