You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The only remaining compatibility is that of gutenberg_show_privacy_policy_help_text. I could not find an equivalent core compatibility. The one here assumes wrongly that Gutenberg will upgrade the notices, which was removed as part of #12444 . This requires more work. In the meantime, the code in lib/compat.php has been left as-is.
Testing instructions:
Verify there are no regressions in the loading of the editor.
aduth
added
Good First Review
A PR that's suitable for someone looking to contribute for the first time by reviewing code
and removed
Good First Review
A PR that's suitable for someone looking to contribute for the first time by reviewing code
labels
Jan 23, 2019
The only remaining compatibility is that of gutenberg_show_privacy_policy_help_text. I could not find an equivalent core compatibility. The one here assumes wrongly that Gutenberg will upgrade the notices, which was removed as part of #12444 . This requires more work. In the meantime, the code in lib/compat.php has been left as-is.
In doing some further investigation and in discussing with @desrosj , it's true that this compatibility does not exist. However, the logic lingering here in lib/compat.php does nothing to help, and thus I'm inclined to defer to a core revision to reimplement the notice for the block editor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good First ReviewA PR that's suitable for someone looking to contribute for the first time by reviewing codeGutenberg PluginIssues or PRs related to Gutenberg Plugin management related efforts
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #11015
This pull request seeks to remove (deprecated) logic in
lib/compat.phpassumed to be present in core.The primary core tracking issue is:
The only remaining compatibility is that of
gutenberg_show_privacy_policy_help_text. I could not find an equivalent core compatibility. The one here assumes wrongly that Gutenberg will upgrade the notices, which was removed as part of #12444 . This requires more work. In the meantime, the code inlib/compat.phphas been left as-is.Testing instructions:
Verify there are no regressions in the loading of the editor.