UIP-2889 Use dependency_validator#126
Merged
greglittlefield-wf merged 2 commits intoWorkiva:masterfrom Nov 17, 2017
Merged
Conversation
RavenNumber of Findings: 0 |
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=======================================
Coverage 94.42% 94.42%
=======================================
Files 31 31
Lines 1559 1559
=======================================
Hits 1472 1472
Misses 87 87 |
Contributor
|
+1 |
rmconsole-wf
changed the title
Contributor
|
QA +10
Merging. @Workiva/release-management-pp |
Contributor
|
+1 to merging this without consumer testing being performed without being explicitly marked as unnecessary |
|
RM +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
Now that
dependency_validatoris published we should use it.How it was fixed:
dependency_validatoras a dev dep and runs its check during CI.Testing suggestions:
Potential areas of regression:
N/A
FYA: @Workiva/ui-platform-pp @Workiva/web-platform-pp