added missing dependency browser_detect

[denniskaselow]

Added browser_detect to dependencies because it is imported in over_react but only included via dart_dev in dev_dependencies. Deploying an application without it fails, because browser_detect.dart returns with a 404.

[aviary2-wf]

Raven

Number of Findings: 0

[codecov-io]

Current coverage is 97.03% (diff: 100%)

Merging #17 into master will not change coverage

@@             master        #17   diff @@
==========================================
  Files            27         27          
  Lines          1211       1211          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1175       1175          
  Misses           36         36          
  Partials          0          0          

Powered by Codecov. Last update 11ac5f5...be67975

[johncblandii]

I'm curious how you're deploying. You shouldn't have to directory every dependency another lib uses.

[denniskaselow]

browser_detect is used in over_react in imports, but it's never included under dependencies (neither as a direct nor as a transitive dependency). The import only works, because it's used by dart_dev which is included under dev_dependencies.

I'm deploying using pub serve in WebStorm.

[denniskaselow]

The output of pub build would look like this, BTW:

Loading source assets...
Loading dart_to_js_script_rewriter, reflectable, over_react and reflectable/src/transform_import transformers...
Building scheduler_react...
[Info from Dart2JS]:
Compiling scheduler_react|web/main_reflectable_original_main.dart...
[Error from Dart2JS on scheduler_react|web/main_reflectable_original_main.dart]:
packages\over_react\src\component\resize_sensor.dart:22:1:
Can't read 'package:browser_detect/browser_detect.dart' (Could not find asset browser_detect|lib/browser_detect.dart.).
import 'package:browser_detect/browser_detect.dart';
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[Dart2JS on scheduler_react|web/main_reflectable_original_main.dart]:
6 warning(s) suppressed in package:scheduler_react.
[Dart2JS on scheduler_react|web/main_reflectable_original_main.dart]:
1 warning(s) suppressed in package:over_react.
[Warning from Dart2JS on scheduler_react|web/main_reflectable_original_main.dart]:
1 hint(s) suppressed in package:w_flux.
[Info from Dart2JS]:
Took 0:00:05.187851 to compile scheduler_react|web/main_reflectable_original_main.dart.
[Info from Dart2JS]:
Compiling scheduler_react|web/main.dart...
[Error from Dart2JS on scheduler_react|web/main.dart]:
packages\over_react\src\component\resize_sensor.dart:22:1:
Can't read 'package:browser_detect/browser_detect.dart' (Could not find asset browser_detect|lib/browser_detect.dart.).
import 'package:browser_detect/browser_detect.dart';
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[Dart2JS on scheduler_react|web/main.dart]:
6 warning(s) suppressed in package:scheduler_react.
[Dart2JS on scheduler_react|web/main.dart]:
1 warning(s) suppressed in package:over_react.
[Warning from Dart2JS on scheduler_react|web/main.dart]:
1 hint(s) suppressed in package:w_flux.
[Warning from Dart2JS on scheduler_react|web/main.dart]:
2 hint(s) suppressed in package:reflectable.
[Info from Dart2JS]:
Took 0:00:02.303213 to compile scheduler_react|web/main.dart.
Build failed.

[johncblandii]

Can you paste your pubspec? I just pulled the project and it worked fine on my end with pub get and pub serve.

[johncblandii]

I'm also on Dart 1.20.1 on this computer.

[johncblandii]

@denniskaselow I put together a simple app to show OverReact in action without defining browser_detect: https://github.com/johncblandii/over_react_sample.

If you could provide more info on your setup, I'm happy to help troubleshoot even more.

[denniskaselow]

Remove the dev_dependencies (or just dart_dev) from your sample project and it will no longer work.

[johncblandii]

Why would you do that? dart_dev rocks. ;-) hehe.

I do see ResizeSensor uses browser_detect.dart so referencing in dependencies makes since.

[aaronlademann-wf]

+1

Thank you for contributing @denniskaselow!

FYI @greglittlefield-wf @clairesarsam-wf @jacehensley-wf @joelleibow-wf

@leviwith-wf this is ready for QA + merge.

[leviwith-wf]

QA Resource Approval: +10

• browser_detect imports successfully when dart_dev is excluded.

---

• Testing instruction
• Dev +1's
• Dev/QA +10

Merging

[colefeisthamel-wf]

RM +1 manually reviewed dependencies