CPLAT-3093 Add ErrorBoundary Component#266
Merged
rmconsole6-wk merged 3 commits into1.31.0_release_basefrom Mar 11, 2019
Merged
CPLAT-3093 Add ErrorBoundary Component#266rmconsole6-wk merged 3 commits into1.31.0_release_basefrom
rmconsole6-wk merged 3 commits into1.31.0_release_basefrom
Conversation
+ In preparation for React16 error boundary capabilities!
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
greglittlefield-wf
requested changes
Mar 11, 2019
Contributor
greglittlefield-wf
left a comment
greglittlefield-wf
left a comment
There was a problem hiding this comment.
One comment otherwise looks great!
Co-Authored-By: aaronlademann-wf <aaron.lademann@workiva.com>
Contributor
Author
|
+1 to Greg's suggestion |
greglittlefield-wf
approved these changes
Mar 11, 2019
aaronlademann-wf
force-pushed
the
CPLAT-3093_dummy-error-boundary-utils
branch
from
b01a05f to
7496192
Compare
Contributor
|
+10 |
Contributor
Author
|
@Workiva/release-management-pp |
9 tasks
7 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
In preparation for React16 error boundary capabilities, we should provide a canonical
ErrorBoundarycomponent.How it was fixed:
Add the
ErrorBoundarycomponent.Testing suggestions:
Potential areas of regression:
None, new feature only.