CPLAT-2281 optimize copy unconsumed props

[joebingham-wk]

Motivation

To increase the performance of forwarding props, we are adding the addUnconsumedProps and addUnconsumedDomProps methods.

Changes

• Add the addUnconsumedProps and addUnconsumedDomProps methods
• Deprecate the copyUnconsumedProps and copyUnconsumedDomProps methods
• Change _validDomProps from a SplayTree to a Set

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

• Tests were updated and provide good coverage of the changeset and other affected code
• Manual testing was performed if needed
  • Steps from PR author:
  • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

• A Client Platform member has reviewed these changes
• There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
• For release PRs - Version metadata in Rosie comment is correct

[aviary2-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[aaronlademann-wf]

Sorry it took so long for me to get to this @joebingham-wk !

Looking good... nearly there.

[aaronlademann-wf]

+1

Can you post the perf data for this change for posterity?

[joebingham-wk]

Yep! Here's the spreadsheet with all of the tests recorded:
https://sandbox.wdesk.com/a/QWNjb3VudB81NDg4MTEzOTQ5OTk5MTA0/spreadsheet/c270726ab395458586aae2b90b309fa4/-1/sheet/2a9eefcc19134f91838d8d16d9a8622a

Summery:
Using addProps(copyUnconsumedProps):

• Average Time: 180ms
• Range: 78ms (with outlier) / 33ms (without outlier)

Using modifyProps(addUnconsumedProps):

• Average Time: 165.76ms
• Range: 14ms

Speed Increase: 8%

[greglittlefield-wf]

+10

@Workiva/release-management-pp