UIP-1436 Upgrade to React 15.4.1#31
Conversation
RavenNumber of Findings: 0 |
Current coverage is 97.44% (diff: 100%)@@ master #31 diff @@
==========================================
Files 27 27
Lines 1209 1286 +77
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1176 1253 +77
Misses 33 33
Partials 0 0
|
| /// A class that provides namespacing for static DOM component factory methods, much like `React.DOM` in React JS. | ||
| abstract class Dom { | ||
| /// Returns a new [DomPropsMixin] that renders an `<a>` tag with getters/setters for all DOM-related React props | ||
| static DomProps a() => new DomProps(react.a); |
There was a problem hiding this comment.
@jacehensley-wf why would be changed from DomProps to SvgProps? (Same with all other related changes)
Isn't this a breaking change?
Is it necessary to change the type just so that it can be used within an <svg> element?
If its not possible to use Dom.a within an SVG context, could we just namespace like this instead?
abstract class Dom {
static DomProps a() => new DomProps(react.a);
static SvgProps svgA() => new SvgProps(react.a);
static DomProps audio() => new DomProps(react.audio);
static SvgProps svgAudio() => new SvgProps(react.audio);
// ... etc ...
}There was a problem hiding this comment.
This isn't a breaking change since SvgProps is a child of DomProps, but I suppose we could keep existing factories and just add name spaced ones like you mention.
|
+1 |
|
+1 |
|
+1 |
|
QA Resource Approval: +10
Merging to Master. Note, this will not be released until infosec vulnerability checks are complete, and dependency tracking via smithy is configured. |
aaronlademann-wf
changed the title
7 participants
Ultimate problem:
ReactJS 15.4.0 was released, we should upgrade to that.
Update:
ReactJS 15.4.1 was released.
How it was fixed:
react_dom_prod.jsin tests sincereact_domnow exports the addons.Testing suggestions:
Potential areas of regression: