Skip to content

CPLAT-6123 3.1.0 wip component factory setter#315

Merged
aaronlademann-wf merged 7 commits into3.1.0-wipfrom
3.1.0-wip-componentFactorySetter
Jul 3, 2019
Merged

CPLAT-6123 3.1.0 wip component factory setter#315
aaronlademann-wf merged 7 commits into3.1.0-wipfrom
3.1.0-wip-componentFactorySetter

Conversation

@kealjones-wk
Copy link
Contributor

Motivation

In order to utilize JS based HOC's such as forwardRef and connect we need the ability to set the component factory of Props on the fly.

Changes

changes componentFactory to a field and update generated code to include on override factory

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aaronlademann-wf aaronlademann-wf merged commit 0e7500f into 3.1.0-wip Jul 3, 2019
@aaronlademann-wf aaronlademann-wf changed the title 3.1.0 wip component factory setter CPLAT-6123 3.1.0 wip component factory setter Jul 8, 2019
@aaronlademann-wf aaronlademann-wf added this to the 3.1.0 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants